Ticket import: persist rank, promote new device to Server#139
Open
passcod wants to merge 1 commit into
Open
Conversation
…, and trusts the device The previous upsert built a Server value with rank/cloud/parent_server_id but never plugged them into the .values()/.set() clauses, so they were silently dropped on import. Operators had to fix rank by hand every time. Likewise, the device created for the ticket's public key inherited the DeviceRole::Untrusted default, leaving the operator to flip it to Server manually. The ticket carries the operator's trust signal, so promote any Untrusted device on import. Update-on-conflict now re-applies all ticket-derived fields (name, host, kind, rank, device_id, parent_server_id, cloud). Operator-edited state (listed, geolocation, alert_when_down) is preserved across re-imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in `Server::upsert_from_ticket` that meant operators had to fix things by hand after every import:
The update path now also re-applies kind/rank/cloud/parent_server_id so a re-import propagates ticket-side changes. Operator-edited state (`listed`, `geolocation`, `alert_when_down`) is preserved.
Tests