Attach tailnet identity over an Untrusted placeholder#137
Merged
Conversation
…laimant A tailnet first-contact auto-creates an Untrusted Device row holding the node id. When the operator subsequently binds that node id to a real device (mTLS-based or otherwise non-Untrusted), the placeholder claim should not stand in the way — detach the identity from the Untrusted row and proceed. Trusted-role conflicts still error out so the operator goes through the merge flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Device::attach_tailscalenow treats an existing Untrusted holder of the sametailscale_node_idas a placeholder: it clears that row'stailscale_*columns and proceeds with the requested attachment, all in a single transaction.DeviceTailscaleNodeAlreadyClaimed(HTTP 409) so the operator goes through the merge flow.Why
Tailnet first-contact auto-creates an Untrusted
Devicerow keyed to the node id. When the operator later wires that node id onto a real (mTLS / server-role / etc.) device, the placeholder claim previously blocked the operation. Detaching it is the right move — the placeholder has no other data worth preserving and the operator's intent is clear.