Render markdown/safe-HTML in issue messages with raw toggle#136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some event providers send issue messages formatted with markdown; others with limited HTML. Previously both were rendered as a monospace
<pre>block, which was robust but looked terrible.Markdowncomponent to also accept inline HTML, sanitised against rehype-sanitize's default GitHub-compatible schema. Scripts, inline event handlers, iframes and the like are stripped;<b>,<a>,<code>, lists, etc. pass through. Adds apreserveNewlinesoption that turns soft line breaks into<br>for log-like input where newlines are significant.MessageViewcomponent renders the message throughMarkdownand adds a small icon toggle in the top-right to flip to the raw text (monospace, pre-wrap) for cases where the rendering hides detail that matters.IssueRow's expanded body now usesMessageViewinstead of the raw<pre>block.Added deps:
rehype-raw,rehype-sanitize,remark-breaks.