Add option to skip generating scope#28
Open
tylercallahan wants to merge 1 commit intobetterup:masterfrom
Open
Conversation
This adds a `:scopes` option to `boolean_timestamps` that allows the user to skip generating the scope. This may be desirable in particular when the generated scope conflicts with an existing Rails method. For example, `boolean_timestamps :loaded_at` attempts to create a scope `:loaded` and raises an error because the method `:loaded` is already defined. Adding the `scopes: false` option avoids the error. Fixes betterup#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
:scopesoption toboolean_timestampsthat allows the user to skip generating the scope. This may be desirable in particular when the generated scope conflicts with an existing Rails method.For example,
boolean_timestamps :loaded_atattempts to create a scope:loadedand raises an error because the method:loadedis already defined. Adding thescopes: falseoption avoids the error.Fixes #7