Merged
Conversation
Co-authored-by: Maxwell <145994855+ping-maxwell@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…port (better-auth#4210) Co-authored-by: Alex Yang <himself65@outlook.com>
…r-auth#7752) Co-authored-by: Alex Yang <himself65@outlook.com>
…ter-auth#8131) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…ema to avoid confusion (better-auth#8141) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alex Yang <himself65@outlook.com>
Syncs the fork with upstream v1.5.4. Key upstream changes: - Kysely adapter extracted to standalone packages/kysely-adapter package - CLI generators updated (FieldType -> DBFieldType, improved Prisma v7+ support) - New @better-auth/kysely-adapter, prisma-adapter, mongo-adapter, drizzle-adapter packages - Various bug fixes and improvements across core, plugins, and adapters Conflict resolution: accepted upstream for all upstream packages; kept fork-specific README and packages/btst/* unchanged. Made-with: Cursor
## Upstream sync (better-auth v1.4.5 → v1.5.4) - Merged upstream/main into branch - Kysely adapter vendored from new packages/kysely-adapter/src/ location (extracted from better-auth monorepo into standalone package in v1.5.4) - Added d1-sqlite-dialect.ts (Cloudflare D1 support) - CLI generators updated: FieldType → DBFieldType, improved Prisma v7+ support - Added helper.ts utility (tryCatch, generateSecretHash) to CLI sync ## @BTST package updates - All packages bumped from v2.0.3 → v2.1.0 - peerDependency better-auth: >=1.4.0 → >=1.5.0 - Added packages/btst/adapter-kysely/src/utils/string.ts (local capitalizeFirstLetter) - generators/index.ts: generateMigrations → generateKyselySchema (deprecated alias kept) ## Build/tooling - pnpm-workspace.yaml: added unbuild and vitest back to default catalog (upstream removed them; our @BTST packages still need them) - Updated snapshot tests for new drizzle/prisma generator output ## Docs - Added WEEKLY-SYNC-UPSTREAM.md with step-by-step sync runbook - Updated scripts/sync-upstream.ts with improved comments and transforms Made-with: Cursor
…ync learnings Made-with: Cursor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Remove duplicate `domainVerificationBodySchema` declaration in packages/sso/src/routes/domain-verification.ts — merge conflict artifact where both sides of the conflict were kept - Fix getMigrations import in packages/btst/cli/src/commands/migrate.ts from 'better-auth/db' (barrel, does not export getMigrations) to 'better-auth/db/migration' (correct subpath) Made-with: Cursor
- Fix biome lint errors across packages/btst/* (organizeImports, useImportType, useNodejsImportProtocol) via pnpm lint:fix - Fix 12 unused `stdout` variable warnings in e2e-cli.test.ts by prefixing unused destructured vars with _ (stdout: _stdout) - Add WEEKLY-SYNC-UPSTREAM.md and packages/btst/**/*.md to .remarkignore so fork-internal docs skip upstream remark-lint rules - Update 4 generate-all-orms snapshots to match new generator output (indentation style changed in v1.5.4 upstream generators) Made-with: Cursor
…and e2e.yml Upstream uses a private self-hosted runner (starsling-ubuntu-24.04) that is not registered in our fork. Jobs on that runner queue forever. Swap to github-hosted ubuntu-latest so lint, typecheck, build, test, smoke, and integration checks actually execute. Also document this as a required post-merge step in WEEKLY-SYNC-UPSTREAM.md. Made-with: Cursor
…add new entries to cspell names and tech-terms
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| yultyyev | ||
| Fyrlex | ||
| alexasomba | ||
| Vijit |
There was a problem hiding this comment.
Duplicate entry in cspell dictionary file
Low Severity
Vijit appears twice in .cspell/names.txt — on line 6 and again on line 19. Both are newly added entries in this diff. The duplicate serves no purpose and adds clutter to the dictionary.
Tests spawning child node processes (info.test.ts) and tests running getConfig with jiti/c12 (get-config.test.ts) are significantly slower in CI coverage runs than locally. Increase describe-level timeouts to accommodate slower CI environments with Istanbul instrumentation. Made-with: Cursor
With Istanbul coverage instrumentation on GitHub Actions runners, scim-users tests run 8-12x slower than local (e.g. 12420ms vs 1469ms). Bump testTimeout from 10_000 to 30_000 to match the cli package fix. Made-with: Cursor
GitHub Actions runners run tests 8-12x slower than local with Istanbul coverage instrumentation. Proactively raise testTimeout from 10_000 to 30_000 in stripe, api-key, oauth-provider, sso, and better-auth to prevent whack-a-mole CI timeouts. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Mostly workflow and tooling changes, but it significantly alters CI/release execution (Node 24, coverage-based tests, new/removed workflows), which could cause pipeline regressions if misconfigured.
Overview
Syncs upstream repo maintenance/tooling updates, with a major refresh of GitHub Actions and repo lint/format infrastructure.
CI/E2E workflows are reworked to use
.nvmrc(now Node24), update caching, add per-job concurrency, run tests viapnpm coverage, improve Docker readiness (docker compose --wait), and skip heavier jobs in merge queues; E2E now uses a sharedsetup-playwrightcomposite action and adds an adapter-integration matrix job. The oldadapter-testsand automated cherry-pick workflows are removed, and new workflows are added fordemoinstalls, manualnpm dist-tag, andclaude-code-actionautomation.Tooling/docs updates include new
remarkconfig for markdown formatting checks, tighterbiomelint rules (incl. restrictingBufferusage inpackages/**/src), expandedcspelldictionaries/regex ignores, new release/sync/postmortem/AI-guidance docs, and an added Electron demo app scaffold underdemo/electron.Written by Cursor Bugbot for commit 39dcfce. This will update automatically on new commits. Configure here.