Pin pip-core to @3.9.2 (drop @latest)#43
Merged
Conversation
@latest is convenient but jsdelivr's edge-caches it for ~12h, so a fresh pip release doesn't reach the dashboard until the edge revalidates. Pinning the version in the URL makes the bytes immutable: the dashboard runs exactly the pip-core it asked for, no waiting on edge TTL or browser cache lag. Cost: a per-release URL bump here. Worth it — every pip-core update also touches the dashboard's pre-commit hook (sw.js VERSION stamp), so the bump rides on a normal commit, not a separate workflow.
There was a problem hiding this comment.
Pull request overview
Pins the dashboard’s pip-core CDN import to a specific released version to avoid jsDelivr @latest edge-cache lag that can leave the dashboard temporarily loading an older build after a publish.
Changes:
- Pin
PIP_CDN_URLindocs/pip/assistant.jsfrom@latestto@3.9.2, with explanatory rationale for future bumps. - Update the service worker cache VERSION stamp in
docs/sw.js(asset-hash bump) so clients receive the updated dashboard assets promptly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/sw.js | Bumps the SW cache version string so the updated dashboard assets roll out. |
| docs/pip/assistant.js | Pins pip-core jsDelivr URL to @3.9.2 to eliminate @latest propagation lag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/pip/assistant.jsimported pip-core via@latest, which jsdelivr edge-caches for ~12 hours. A fresh pip publish doesn't reach the dashboard until the edge revalidates — observed today when pip-core 3.9.2 was published but the dashboard kept loading 3.9.1, breaking/model+ Enter behavior despite the fix being live on npm.Pin the exact version in the URL (Stripe / AWS pattern). The URL is immutable bytes — what the dashboard asks for is what it gets, no edge TTL lag. Cost: a per-release URL bump here. Worth it — pip-core updates already touch the dashboard's pre-commit hook (sw.js VERSION stamp), so the bump rides on a normal commit, not a separate workflow.
Bumping in the future
When a new pip-core ships:
PIP_CDN_URLindocs/pip/assistant.jsto the new@x.y.zsw.js)Test plan
make smoke(41/41)pip-core@3.9.2(verify in Network tab — the URL itself shows the version)/model+ Enter opens the provider picker (the fix this whole excursion was about)