Drop local backend + Gemma 4; /model and /vision Enter opens picker#42
Merged
Conversation
Two changes packaged because they touch the same slash surface:
1. Remove the `local` backend entirely. claude.js loses _localAsk,
_localAskWithTools, loadLocalProvider, the LOCAL_PROVIDER_URL CDN
import, and the `local` branches in ask() / askWithTools() /
activeModelForBackend(). assistant-slash.js drops "local" from
PIP_PROVIDERS and removes the WebGPU-gated `/model local` handler.
assistant.js drops "local" from the onboarding picker labels +
hasCredentialsForBackend. settings.js drops pipLocalModel /
pipLocalDtype defaults. callToolWithHooks stays — still used by
anthropic + openai tool loops.
2. `/model` and `/vision` with no args now return
{ openCompletions: true } instead of { reply: ... } help text.
pip-core surfaces this as "re-open the arg-mode dropdown as a
sub-menu" — so `/model` + Enter shows the provider picker right
below the input instead of dumping help text into chat. Same shape
for `/vision` (pip / detector picker). Removed the now-unused
visionStatus() helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes packaged because they touch the same slash surface:
1. Remove the
localbackend entirelyclaude.jsloses_localAsk,_localAskWithTools,loadLocalProvider, theLOCAL_PROVIDER_URLCDN import, and thelocalbranches inask()/askWithTools()/activeModelForBackend().assistant-slash.jsdrops"local"fromPIP_PROVIDERSand removes the WebGPU-gated/model localhandler.assistant.jsdrops"local"from the onboarding picker labels +hasCredentialsForBackend.settings.jsdropspipLocalModel/pipLocalDtypedefaults.callToolWithHooksstays — still used by anthropic + openai tool loops.Net: −226 lines.
2.
/model+ Enter → opens picker/modeland/visionwith no args now return{ openCompletions: true }instead of{ reply: ... }help text. pip-core surfaces this as "re-open the arg-mode dropdown as a sub-menu" — so/model+ Enter shows the provider picker right below the input instead of dumping help text into chat. Same shape for/vision(pip / detector picker). Removed the now-unusedvisionStatus()helper.Test plan
make smoke(41/41)node --checkacross touched files/model+ Enter → dropdown shows providers (github,bridge,anthropic,openai); selecting one switches backend/vision+ Enter → dropdown showspip/detector; selecting one re-opens with second-level options/model local→ "Unknown providerlocal" (no longer valid)