fix: during oauth login restore action from url#13
Open
roock wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening an url like:
/Ticket/Display.html?id=35&Action=TakeThe second query parameter is lost during the oauth redirect(s).
(Sorry, language of the Screenshot is in German)
This is due to the fact that
$args->{next}only contains the first query parameter.Additonally the whole state needs to be uri_escaped, otherwise the param will get lost during the redirect to the oauth2 provider.
The supplied patch is not perfect, but hopefully a good starting point to solve this issue.