Skip to content

Perform LDAP UNBIND operation on disconnect #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdragon300 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Perform LDAP UNBIND operation on disconnect #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/RT/Authen/ExternalAuth/LDAP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ sub GetAuth {
ldap_error_name($ldap_msg->code),
$ldap_msg->code);
# Didn't even get a partial result - jump straight to the next external auth service
$ldap->unbind;
return 0;
}

Expand All @@ -211,6 +212,7 @@ sub GetAuth {
$username,
"User not found or more than one user found");
# We got no user, or too many users.. jump straight to the next external auth service
$ldap->unbind;
return 0;
}

Expand Down Expand Up @@ -278,6 +280,7 @@ sub GetAuth {
$ldap_msg->code);

# Fail auth - jump to next external auth service
$ldap->unbind;
return 0;
}

Expand All @@ -291,6 +294,7 @@ sub GetAuth {
$username);

# Fail auth - jump to next external auth service
$ldap->unbind;
return 0;
}
}
Expand All @@ -303,6 +307,7 @@ sub GetAuth {
$service,
"):",
$username);
$ldap->unbind;
return 1;

}
Expand Down Expand Up @@ -485,6 +490,7 @@ sub UserExists {
")",
$username,
"User not found");
$ldap->unbind;
return 0;
} elsif ($user_found->count > 1) {
# If more than one result returned, die because we the username field should be unique!
Expand All @@ -493,11 +499,13 @@ sub UserExists {
")",
$username,
"More than one user with that username!");
$ldap->unbind;
return 0;
}
undef $user_found;

# If we havent returned now, there must be a valid user.
$ldap->unbind;
return 1;
}

Expand Down Expand Up @@ -575,9 +583,11 @@ sub UserDisabled {
# we are going to assume the user should be disabled
if ($disabled_users->count) {
undef $disabled_users;
$ldap->unbind;
return 1;
} else {
undef $disabled_users;
$ldap->unbind;
return 0;
}
}
Expand Down