Skip to content

small fixes #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertmelis merged 3 commits into from
Dec 21, 2025
Merged

small fixes #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6654763
fix warning
bertmelis Dec 21, 2025
f1293f0
relax idf requirements
bertmelis Dec 21, 2025
94609a3
fix examples
bertmelis Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/largepayload-esp8266/largepayload-esp8266.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

mqttClient.loop();
if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
Expand Down
3 changes: 2 additions & 1 deletion examples/notask-esp32/notask-esp32.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/ota-esp8266/ota-esp8266.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ void loop() {
ESP.reset();
}

static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

mqttClient.loop();

Expand Down
3 changes: 2 additions & 1 deletion examples/simple-esp32-idf/main/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/simple-esp32/simple-esp32.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/simple-esp8266/simple-esp8266.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

mqttClient.loop();
if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
Expand Down
3 changes: 2 additions & 1 deletion examples/simpleAsync-esp32/simpleAsync-esp32.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/simpleAsync-esp8266/simpleAsync-esp8266.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/tls-esp32/tls-esp32.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
connectToMqtt();
Expand Down
3 changes: 2 additions & 1 deletion examples/tls-esp8266/tls-esp8266.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ void setup() {
}

void loop() {
static uint32_t currentMillis = millis();
static uint32_t currentMillis = 0;
currentMillis = millis();

mqttClient.loop();
if (reconnectMqtt && currentMillis - lastReconnect > 5000) {
Expand Down
2 changes: 1 addition & 1 deletion idf_component.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
espressif/arduino-esp32: ^3.1.1
idf: ">=5.3,<5.5"
idf: ">=5.3"
description: an MQTT client for the Arduino framework for ESP8266 / ESP32
url: https://github.com/bertmelis/espMqttClient
version: 1.7.0
2 changes: 1 addition & 1 deletion src/MqttClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ MqttClient::MqttClient(espMqttClientTypes::UseInternalTask useInternalTask, uint
xTaskCreate((TaskFunction_t)_loop, "mqttclient", EMC_TASK_STACK_SIZE, this, priority, &_taskHandle);
(void) core;
#else
if (core >= 0 && core < 2) {
if (core < 2) {
xTaskCreatePinnedToCore((TaskFunction_t)_loop, "mqttclient", EMC_TASK_STACK_SIZE, this, priority, &_taskHandle, core);
} else {
xTaskCreate((TaskFunction_t)_loop, "mqttclient", EMC_TASK_STACK_SIZE, this, priority, &_taskHandle);
Expand Down