Sleep followup#1
Closed
ze-dom wants to merge 576 commits intobernatvadell:feat/skill-sleepfrom
Closed
Conversation
When an object with a parent is created in one go, an exception would occur. In this case, it doesn't matter, because the parent of the parent will be updated.
/clearinv - clear inventory /npc - open merchant npc shop /openware - open the warehouse (vault)
/getlevel /getleveluppoints /getmasterlevel /getmasterleveluppoints /getmoney /getresets /setlevel /setleveluppoints /setmasterlevel /setmasterleveluppoints /setmoney /setresets
…xtendsDuration, SB skills rework
Improve NpcChatCommandPlugIn
1. Some navigation types need to be read-only 2. They need to assigned to a game configuration if they're included in its collections The caching of the TypedContext models needed to be adjusted, because otherwise a TypedContext of A would've used a cached model of B.
…save AdminPanel: Fixed creation of DropItemGroups etc.
…Value check - Modified GetValueOfAttribute to use the actual definition from the stored attribute - Added test to verify maximum value is respected from stored definition - All 37 tests pass Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
feat: add max magic speed
Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
- Verify fix works for both StatAttribute and ComposableAttribute - All 38 tests pass Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
…attribute Fix: Use actual stored AttributeDefinition for MaximumValue capping
Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
Co-authored-by: sven-n <5238610+sven-n@users.noreply.github.com>
…e-error Fix PostgreSQL 18+ Docker compatibility and remove obsolete version fields
feat: toggleable prevent experience overflow on level up
…class Refactor invasion plugin system to use a dedicated record class instead of tuple types, improving type safety and code maintainability. This also includes optional spawn coordinates, instead of a default global random spawn. Changes: - Add InvasionMobSpawn record class with optional spawn coordinates - Replace tuple types in BaseInvasionPlugIn with InvasionMobSpawn[] - Add support for optional x1, x2, y1, y2 coordinates per spawn entry - Update SpawnMobsAsync to accept IEnumerable<InvasionMobSpawn> - Update GoldenInvasionPlugIn and RedDragonInvasionPlugIn to use new class Benefits: - Single class type can be used throughout codebase - Named parameters improve code readability - Easier to extend with additional properties in the future - Enables grouped spawning by specifying custom coordinates The InvasionMobSpawn class supports: - Default behavior: spreads monsters across entire map (10-240, 10-240) - Custom coordinates: specify exact spawn area for grouped spawning - Map selection: MapId null = selected map, MapId set = specific map
…ctor to better reflect usual structure (x1,y1,x2,y2)
…sions on fixed maps only
feat: allow partial pick up of zen
refactor: Replace invasion spawn tuples with InvasionMobSpawn record class
Author
|
Closing this due to complexity. But your work will remain with my future PR 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @bernatvadell !
I'm looking to finish the Summoner skills, and I thought I would pick up where you left. I hope it's ok with you.
This is my proposal so we can discuss with sven. If you merge this, I think it will appear on your PR, right?
I've checked out and updated your branch feat/skill-sleep with master, hence the huge amount of commits.