Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some older games seem to initialise PERIODIC FFB only a single time, proceeding to then update the values continuously. If this initialisation fails, then no steering FFB will be present.
One such game is GT Legends, and other games using the same engine likely do the same. Initialisation in this case seems to be done with a period of "0", which is naturally invalid; Proton versions >= 7.0 pass this value directly to the driver (where versions < 7.0 instead pass a period of "1", presumably intercepting the bad value), which causes FFB to fail.
This branch adds the
--period-fixoption, which will intercept any period value == 0 and convert it to 1. Using this new value fixes FFB in GT Legends. Hopefully more people will be able to test this with other games using the same engine.