Add IPv6 client support with Happy Eyeballs#150
Merged
Conversation
- Resolve hostnames in the caller and race addresses IPv6-first, returning errors instead of dialing localhost - Accept IP-tuple and bracketed IPv6 literal hosts; add family, happy_eyeballs, connection_attempt_delay and connect_timeout options - Reopen the migration socket with the connection's address family - Supervise connection attempts and Happy Eyeballs coordinators; monitor the owner so a supervised connection closes with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds IPv6 to the client connect path.
quic:connect/4now accepts IP-tuple and bracketed IPv6 literal hosts, resolves hostnames in the caller process (returning{error, _}instead of silently dialing localhost on failure), and uses RFC 8305 Happy Eyeballs for dual-stack hostnames: addresses are raced IPv6-first and the first to finish its handshake is returned. For a multi-address hostnameconnect/4blocks until the first attempt connects; a single address, IP literal/tuple, or pre-opened socket keeps the immediate async return.The migration rebind now reopens the socket with the connection's address family. Racing attempts and coordinators run under supervision, and connections monitor their owner so a supervised winner closes when its owner exits.
New options:
happy_eyeballs(defaulttrue),family(inet | inet6 | any),connection_attempt_delay(250 ms),connect_timeout(5000 ms).