Fix: guard missing checkCurrentIsDbGraph API to avoid handshake crash#69
Open
alaeri wants to merge 1 commit into
Open
Fix: guard missing checkCurrentIsDbGraph API to avoid handshake crash#69alaeri wants to merge 1 commit into
alaeri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some Logseq builds,
App.checkCurrentIsDbGraphis not exported by the host, which causes the plugin to crash at load time with:This change wraps the call in a
try/catchblock and falls back tofalsewhen the API is unavailable. This prevents the plugin from failing during initialization while preserving existing behavior on builds where the method is supported.Investigation and patch were developed with assistance from ChatGPT.
No other behavior is modified.
Also I couldnt install bunx due to not having room for the xcode update so I couldn't run the lint/test suite but the fix is maybe simple enough?