Ndbm move#299
Merged
benjaminp merged 4 commits intobenjaminp:masterfrom Nov 5, 2019
benbariteau:ndbm_move
Merged
Conversation
Contributor
|
are we missing any more? https://github.com/python/cpython/blob/master/Lib/lib2to3/fixes/fix_imports.py#L8-L58 |
Contributor
|
also some other dbm things https://github.com/python/cpython/blob/master/Lib/lib2to3/fixes/fix_imports2.py#L7-L8 |
Contributor
Author
|
There's a (not finished) PR for one of those. #180 |
Contributor
Author
|
If you want me to add more moves, I'm happy to do so, but this is the one I really care about. |
Contributor
|
I'd like to see a comprehensive PR will all the moves added, but I'm not the maintainer and I believe this package is now unmaintained |
Owner
|
The |
Open
Contributor
Author
|
Should I add the other dbm moves as part of this branch? |
Owner
|
Which are those? |
Contributor
Author
|
anydbm and whichdb |
Contributor
Author
|
ah and dumbdbm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #298