Open
Conversation
The hasattr() function on python2 is famously dangerous and a frequent source of problems. This backports the slighly less dangerous Python 3 version to Python2.
Contributor
|
@benjaminp can you review this pr? |
graingert
reviewed
Sep 11, 2019
| """Return whether the object has an attribute with the given name. | ||
|
|
||
| This is done by calling getattr(obj, name) and catching AttributeError.""" | ||
| try: |
Contributor
There was a problem hiding this comment.
I think
try:
getattr(obj, attr_name)
except AttributeError:
return False
return Trueis a bit nicer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hasattr() function on python2 is famously dangerous and a frequent
source of problems. This backports the slighly less dangerous Python 3 version
to Python2.