[BUGFIX] Fix sticky header flicker via CSS height compensation (alternative to #1618)#1619
Open
CybotTM wants to merge 1 commit into
Open
Conversation
The navbar uses position:sticky, so height changes affect document flow. When navbar-transition reduces --mainnavigation-nav-height to the xs value (70px), the document shrinks, causing scrollbar jumps and scroll-position oscillation in Chromium browsers. Add compensating margin-bottom computed from $navbar-heights map: the difference between each breakpoint's default height and the transition height (xs). This keeps document height constant while the navbar still visually shrinks. Resolves: benjaminkott#1424 Resolves: benjaminkott#1468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Same issue as #1618 — sticky navbar flickers during scroll transition in Chromium browsers (#1424, #1468).
Alternative approach: fix the root cause, not the symptom
PR #1618 fixes the symptom (scroll oscillation) by replacing the hardcoded JS threshold with a dynamic one. This PR fixes the root cause (document height instability) with a CSS-only approach.
Why the document height changes
.navbar-fixed-topusesposition: sticky. Whennavbar-transitionis added,--mainnavigation-nav-heightdrops from the responsive default (lg: 100px, xl: 110px) to 70px (xs). Since sticky elements remain in document flow, this shrinks the document by 30-40px, causing:Fix: compensate with margin-bottom
Comparison with #1618
$navbar-heights)Both PRs are valid. They can also be combined — the CSS fix prevents the root cause while the JS fix adds an extra safety margin. The maintainer can choose whichever approach fits best.
Running in production: https://typo3-demo.netresearch.de (CSS fix only, original stickyheader.js)
Resolves #1424
Resolves #1468
Prerequisites
cd Build; npm ci; npm run build) — SCSS change only, CSS rebuild needed