Skip to content

FIX Mantis solver: align with updated Linear Probe Adapter#41

Merged
felixdivo merged 3 commits into
benchopt:mainfrom
tgnassou:fix-mantis-linearprobe
Jun 13, 2026
Merged

FIX Mantis solver: align with updated Linear Probe Adapter#41
felixdivo merged 3 commits into
benchopt:mainfrom
tgnassou:fix-mantis-linearprobe

Conversation

@bryan29-ly

Copy link
Copy Markdown
Contributor

PR #34 updated the benchmark_utils/adapters/linear_probe.py but solvers/mantis.py was not completely adapted:

  • run() still passed max_iter=self.max_iter → crash.
  • run() read self.n_estimators, but the parameter was declared as
    n_iterators
  • penalty, C and alpha were declared in parameters but never forwarded
    to the adapter.

Fix

  • Remove the max_iter argument.
  • Rename the n_iterators parameter to n_estimators
  • Forward penalty, C and alpha to the Linear Probe Adapter

cc @ambroiseodt

@felixdivo felixdivo merged commit e7b7d21 into benchopt:main Jun 13, 2026
5 checks passed
@ambroiseodt

Copy link
Copy Markdown
Contributor

Seeing this late @bryan29-ly, seems great! Thanks @felixdivo for merging it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants