Open
Conversation
tiennou
force-pushed
the
fix/store-changes
branch
from
dc5f5ad to
c048630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
This cleans up the wrong interface definition we have over
Store, which breaks TS since it's a type declaration upstream and not an interface. Also provides specific typings for arrays of store contents, updates most of the definitions that have an object-like store-thing ([resourceType: string]: number;) to an explicit type, and switches all of the deprecated before-Store properties to use the new style as well as usingthing.store[RESOURCE_THING]instead of the named property.Testing checklist:
tsconfigconfiguration