Open
Conversation
bencbartlett
requested changes
Feb 4, 2024
Owner
bencbartlett
left a comment
bencbartlett
left a comment
There was a problem hiding this comment.
See comments; please don't include changes to unrelated files in future pull requests, such as editorconfig, gitignore, toolversions, obfuscator, etc. Try to include only the changes which are relevant to the feature you are making the PR for
tiennou
force-pushed
the
feature/roomobject-print
branch
from
49825da to
31c5f9a
Compare
Author
|
Tooling changes removed, and changed the typeguards to use explicit structural checks. |
tiennou
force-pushed
the
feature/roomobject-print
branch
from
31c5f9a to
6cec66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
This adds a RoomObject-level
.printmethod, so that it's safe to print any sort of object. I believe it is missing a couple cases, but it covers most of them.Testing checklist:
tsconfigconfiguration