Switch room status checks to RoomIntel#210
Closed
tiennou wants to merge 4 commits intobencbartlett:devfrom
Closed
Conversation
This switches to Node 20, updates most dependencies to their latest version, and moves the obfuscator config to its own file. Also included is the script I wrote to rewrite a branch into a version that doesn't have the two hidden files in it.
tiennou
force-pushed
the
fix/room-status
branch
from
e554592 to
a3048d7
Compare
Owner
|
Oh sorry I actually just made an equivalent set of changes here a couple of minutes ago: 0e23a85 |
Author
|
Fair. #191 can be closed as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
This changes all of the deprecated uses of
Game.map.isRoomAvailableto go throughRoomIntel.getRoomStatus, which handles caching already, which could have a performance effect since it's costly to check.Testing checklist:
tsconfigconfiguration