Fix guard amount for invaderCore attacking#189
Open
schealex wants to merge 7 commits intobencbartlett:devfrom
Open
Fix guard amount for invaderCore attacking#189schealex wants to merge 7 commits intobencbartlett:devfrom
schealex wants to merge 7 commits intobencbartlett:devfrom
Conversation
amount was always zero because the invaderCore was not accounted for
MatthewARoy
approved these changes
Nov 17, 2020
Collaborator
MatthewARoy
left a comment
MatthewARoy
left a comment
There was a problem hiding this comment.
lgtm, the cores were getting cleaned up but I believe it was only when an invasion would spawn and trigger defense.
We should consider again splitting off this into a more efficient attack/move creep specializing in killing the cores, that was previously handled in the modular dismantle function.
schealex
force-pushed
the
dev
branch
2 times, most recently
from
0083050 to
ec52cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
amount was always zero because the invaderCore was not accounted for
Testing checklist:
tsconfigconfiguration