cherry pick: 0 = false, check for key exists. stop moving managers#177
Open
ikiris wants to merge 1 commit intobencbartlett:devfrom
Open
cherry pick: 0 = false, check for key exists. stop moving managers#177ikiris wants to merge 1 commit intobencbartlett:devfrom
ikiris wants to merge 1 commit intobencbartlett:devfrom
Conversation
Contributor
|
in the master branch, the manager had a value of 1 for a priority, this PR fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
Manager was getting pushed, debuged to this logic bug that 0 fails the test intended to check if the element exists. Replaced with equivalent test logic.
Fixed:
MovePush check incorrectly treating manager 0 value as nonexistent and taking default 10 causing unintended push.
Testing checklist:
tsconfigconfiguration