Skip to content

Comments

lol fixed playerhostiles#172

Open
ikiris wants to merge 1 commit intobencbartlett:devfrom
ikiris:isplayer
Open

lol fixed playerhostiles#172
ikiris wants to merge 1 commit intobencbartlett:devfrom
ikiris:isplayer

Conversation

@ikiris
Copy link

@ikiris ikiris commented May 20, 2020

/facepalm

Pull request summary

Description:

Fixes what appears to be a mistype of isPlayer vs isHuman in the prototypes for creeps / room tracking.

Fixed:

Defenses / safe mode wasn't operating correctly due to not seeing hostile player entities.

  • None

Testing checklist:

  • [x ] Changes are backward-compatible OR version migration code is included
  • [x ] Codebase compiles with current tsconfig configuration
  • Tested changes on {choose PUBLIC/PRIVATE} server OR changes are trivial (e.g. typos)

@bencbartlett
Copy link
Owner

Hi, I've noticed you've made a couple of pull requests recently; thanks for the interest in contributing. The next two of weeks are pretty busy for me so I don't have a lot of time to work on Screeps, but I'll try to review and merge all your pull requests as soon as I can!

@tiennou tiennou mentioned this pull request Feb 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants