Novice protection: detect novice and respawn zones#145
Open
MatthewARoy wants to merge 5 commits intobencbartlett:masterfrom
Open
Novice protection: detect novice and respawn zones#145MatthewARoy wants to merge 5 commits intobencbartlett:masterfrom
MatthewARoy wants to merge 5 commits intobencbartlett:masterfrom
Conversation
semperrabbit
reviewed
Jun 8, 2019
Contributor
|
Is this still useful given that there is now |
Owner
|
No; I will be adding in updated novice zone restrictions in the near future now that that method is in the API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
Tracking novice and respawn zones from LOAN
Added:
Stores novice/respawn rooms in memory with utils to access both
Testing checklist:
Tested in prod with rooms selected from https://screepspl.us/data/shard2.novice.json
console.log(`Room is a respawn room: ${'W21S33'} checking ${Cartographer.isRespawnRoom('W21S33')}`); console.log(`Room is a respawn room: ${'W11S13'} checking ${Cartographer.isRespawnRoom('W11S13')}`);[1:30:01 PM][shard2]Room is a respawn room: W21S33 checking true[1:30:01 PM][shard2]Room is a respawn room: W11S13 checking false