docs: fix stale test count + dashboard route path (BEN-54)#57
Open
benSepanski wants to merge 1 commit intomainfrom
Open
docs: fix stale test count + dashboard route path (BEN-54)#57benSepanski wants to merge 1 commit intomainfrom
benSepanski wants to merge 1 commit intomainfrom
Conversation
PROGRESS.md said `110 unit tests + 5 eval scenarios`; the suite is at 151 + 5 today. FRONTEND.md and product-specs/live-dashboard.md both documented the run-detail route as `#/run/<id>`, but `src/web/App.tsx` parses `runs/` (plural) and `Dashboard.tsx` links there — so the docs sent reviewers to a 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Doc-review pass for BEN-54. Found two factual inaccuracies that send readers
to wrong information: a stale gate-status test count and a wrong dashboard
route in two places.
TL;DR
Update
PROGRESS.mdtest count110 → 151and fix#/run/<id>to#/runs/<id>in the FRONTEND and live-dashboard docs.Summary
PROGRESS.md: gate-status line said110 unit tests + 5 eval scenarios; runningpnpm alltoday reports151 + 5. Updated.docs/FRONTEND.mdanddocs/product-specs/live-dashboard.md: route table + reviewer journey listed#/run/<id>, butsrc/web/App.tsxparsesruns/(plural) andsrc/web/Dashboard.tsxlinks to#/runs/${r.id}. Docs now match the code.Demo
n/a — docs-only edits, no user-visible surface.
Alternatives
docs/QUALITY_SCORE.md, refresh_Last reviewed_stamps, audit every cross-link). Rejected: out of scope for a single cron tick — the existingtech-debt-tracker.mdalready tracks the proposed doc-gardening eval that should automate this. Filing additional fixes belongs in a follow-up ticket.runs/→run/). Rejected:#/runs/<id>is consistent with/api/runs/:idand is what the live UI links to today; renaming would break every existing bookmark + transcript link.Test Plan
pnpm all— typecheck + fmt:check + lint + test (151) + eval (5)pnpm build:web— not run; touched no code, no bundle impactgrep -rn '#/run/' docs/ src/returns nothing after the fix.Generated by Claude Code