fix(web): responsive header + runs grid + turn pre wrapping (BEN-52)#56
Open
benSepanski wants to merge 1 commit intomainfrom
Open
fix(web): responsive header + runs grid + turn pre wrapping (BEN-52)#56benSepanski wants to merge 1 commit intomainfrom
benSepanski wants to merge 1 commit intomainfrom
Conversation
…N-52) * App header now wraps and uses smaller padding below the sm breakpoint; the long run-id span truncates instead of forcing the row wider. * Runs grid is wrapped in an overflow-x-auto container with a 56rem min-width inner section, so on phones the table scrolls horizontally inside the wrapper rather than pushing the page wider than the viewport. * Turn-content and rendered-prompt <pre> blocks add break-words so long unbreakable strings (URLs, tokens) wrap inside the card instead of triggering a horizontal scrollbar. https://claude.ai/code/session_01P3fhTuAWNTQX1nUrLyDDHo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dashboard, header, and turn
<pre>blocks assumed a desktop viewport: a long run-id pushed the header wider than the screen, the 9-column runs grid forced page-level horizontal scroll on phones, and unbreakable strings in turns made<pre>blocks scroll instead of wrap. (Linear: BEN-52.)TL;DR
Wrap the runs grid in an
overflow-x-autocontainer with a 56rem min-width, let the header flex-wrap with smaller padding belowsm, truncate the long run-id, and addbreak-wordsso turn pre-blocks wrap.Summary
App.tsx: header switches from fixedflextoflex flex-wrap, padding drops topx-4 py-3 sm:px-6 sm:py-4, nav links get a 32px tap target viapx-2 py-2, and therun <id>…span usesmin-w-0 max-w-full truncateso a long run-id can't overflow the row. Main padding mirrors the same responsive pattern.Dashboard.tsx:RunsTableis wrapped in<div className="-mx-4 overflow-x-auto sm:mx-0">; the inner<section>hasmin-w-[56rem] sm:min-w-0so on a 375px viewport the grid scrolls horizontally inside the wrapper instead of expanding the page.RunDetail.tsx: the turn-content and rendered-prompt<pre>blocks addbreak-words, so long unbreakable tokens/URLs wrap inside the card rather than triggering a second horizontal scrollbar inside the run page.Demo
n/a — automated cron run with no UI capture.
pnpm all(151 tests + 5 evals) andpnpm build:web(231 kB JS / 23 kB CSS) are green. Manual QA at 375×812 is recommended on the four canonical journeys (empty / live / failed / past) before merge to confirm the page no longer scrolls horizontally.Alternatives
sm— rejected; the column set is only nine items and a horizontal scroll inside its own wrapper preserves the existing reading model and required no template duplication.vitest.config.tsonly globssrc/**/*.test.ts, anddocs/FRONTEND.mdalready tracks "no component-test suite" as known tech debt; pulling in@testing-library/react+ jsdom for one assertion would expand the test stack outside this ticket.Test Plan
pnpm all— typecheck + fmt:check + lint + test (151) + eval (5)pnpm build:web— web bundle builds (231 kB JS, 23 kB CSS)#/,#/runs/<id>,#/searchat 375×812 in DevTools and confirm no page-level horizontal scroll; the runs grid scrolls inside its wrapper; the long run-id in the header truncates instead of wrapping the nav row.https://claude.ai/code/session_01P3fhTuAWNTQX1nUrLyDDHo
Generated by Claude Code