Default the dashboard to loopback-only via --bind (BEN-44)#49
Merged
benSepanski merged 1 commit intomainfrom May 2, 2026
Merged
Default the dashboard to loopback-only via --bind (BEN-44)#49benSepanski merged 1 commit intomainfrom
benSepanski merged 1 commit intomainfrom
Conversation
@hono/node-server's serve() defaults to 0.0.0.0, so the harness was binding the dashboard to all interfaces despite SECURITY.md and the threat model specifying loopback-only. Add a --bind flag to both `run` and `replay`, default it to 127.0.0.1, thread `hostname` into both serve() calls, and reflect the actual contract in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SECURITY.mdandthreat-model.mdclaim the dashboard is loopback-only, but@hono/node-server'sserve()defaults to0.0.0.0, so it was actually exposed on every interface.TL;DR
Default
--bindto127.0.0.1for bothrunandreplay; threadhostnameinto bothserve()calls so the docs match reality.Summary
--bind <host>CLI option (default127.0.0.1) torunandreplay; pass it ashostnametoserve()and surface it in the startup log.--bind 0.0.0.0.tech-debt-tracker.md"Open" to "Resolved (archive)".SECURITY.md,threat-model.md(mitigation Rewrite cloud-setup.sh for reliable Erlang/Elixir install #5 + open gaps), anddocs/product-specs/replay.mdto match.Demo
n/a — backend hardening, no UI surface change.
Alternatives
127.0.0.1with no flag. Rejected: an operator behind their own tunnel may legitimately want LAN exposure, and the tech-debt remediation explicitly called for a flag.bindthrough theWORKFLOW.mdconfig schema. Rejected as scope creep — bind is a per-invocation concern, not a per-workflow one.Test Plan
pnpm all— typecheck + fmt:check + lint + test (120) + eval (5) all pass locally.pnpm build:web— n/a; CLI/docs change only, no web bundle impact.symphony listening on http://127.0.0.1:4000 (...)by default.Closes BEN-44.
Generated by Claude Code