Enable beman-tidy (--require-all mode)#23
Merged
Conversation
8 tasks
|
coverage: 100.0%. remained the same — neatudarius:issue/264-require-all into bemanproject:main |
Member
|
I'd think to commit this the failing item needs to be fixed? Or perhaps exclude the one issue? |
Member
Author
Updated PR description to reflect that. Please comment on bemanproject/beman-tidy#264 (comment) |
Add Godbolt example link so beman-tidy --require-all passes release.godbolt_trunk_version. Issue: bemanproject/beman-tidy#264 Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve README badge conflict by keeping main's markdownlint layout and the Compiler Explorer badge for --require-all. Fix .beman-tidy.yaml empty lists for beman-tidy v0.5.1 compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bemanproject/beman-tidy#264
Enable
beman-tidy --require-allon CI forbeman.transform_view.CODEOWNERS approval: @ednolan approved
--require-allin the issue.Changes
--require-allin.pre-commit-config.yamlhttps://godbolt.org/z/qd6v7Kj5E)Test plan
release.godbolt_trunk_versionpasses with the new badge