Enable beman-tidy --require-all (disable readme.implements until P3610)#63
Merged
neatudarius merged 2 commits intoJul 9, 2026
Merged
Conversation
Disable readme.implements until P3610 is published on WG21, keep the local papers/scope.org link in README, add SPDX headers for file.license_id, and bump beman-tidy to v0.4.1 for disabled_rules support. Co-authored-by: Cursor <cursoragent@cursor.com>
neatudarius
requested review from
JeffGarland,
robert-andrzejuk and
wusatosi
as code owners
This was referenced Jul 9, 2026
Ignore infra/ in .beman-tidy.yaml instead of patching vendored infra files, which broke the beman-submodule consistency check in CI.
|
coverage: 100.0%. remained the same — neatudarius:enable-tidy-require-all into bemanproject:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bemanproject/beman-tidy#260
Supersedes #60 with the approach agreed in the issue discussion.
Per @JeffGarland's feedback, this PR enables
beman-tidy --require-allwhile keeping the local paper link in README and disabling only thereadme.implementscheck until P3610 is published on WG21.Changes
.beman-tidy.yamlwithdisabled_rules: [readme.implements](local draft remains at./papers/scope.org)./papers/scope.org(no broken wg21.link placeholder)file.license_idcompliance (8 config/infra files)args: [".", "--verbose", "--require-all"]in pre-commitTest plan
pre-commit run beman-tidy --all-filespassesbeman-tidy . --verbose --require-allpasses (withreadme.implementsdisabled)Made with Cursor