-
Notifications
You must be signed in to change notification settings - Fork 4
Implement modules support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a18042b
Split scan_view implementation from dependencies
yesmanchyk e1d5324
Copied enable-experimental-import-std.cmake from exemplar
yesmanchyk a4c5ac4
Implement modules support
yesmanchyk a8cd177
Implement modules support in examples
yesmanchyk 811bc6d
Added new line
yesmanchyk f316a48
Fixed test in Clang
yesmanchyk 6ac8a90
CI for modules
yesmanchyk fa8b78b
Apply suggestions from code review
yesmanchyk 649eebf
Apply suggestions from code review
yesmanchyk 1e39a97
Fix lint
yesmanchyk 15fcb10
Fix lint
yesmanchyk 003dd37
CI version bump
yesmanchyk f75a6d1
infra-workflows bump
yesmanchyk 588de8f
Pass correct flag to use modules
yesmanchyk 30d2e85
Revert "Split scan_view implementation from dependencies"
yesmanchyk 12130de
Remove reverted file
yesmanchyk f3ca98b
Use compatibility headers
yesmanchyk 36a3452
Use compatibility headers in tests and examples
yesmanchyk f196c4b
Avoid global module fragment
yesmanchyk 3aef587
beman-submodule update --remote
yesmanchyk e7c1aad
Apply suggestions from code review
yesmanchyk d41698d
Indent includes
yesmanchyk bb40384
clang-format -i include/beman/scan_view/scan.hpp
yesmanchyk 67d2eb4
Put #include <version> to GMF
yesmanchyk ec3b621
Replace size_t with std::size_t
yesmanchyk b65932f
Single #include <gtest/gtest.h>
yesmanchyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yesmanchyk marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,24 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| target_sources(beman.scan_view PUBLIC FILE_SET HEADERS FILES scan.hpp) | ||
| if(BEMAN_SCAN_VIEW_USE_MODULES) | ||
| target_sources( | ||
| beman.scan_view | ||
| PUBLIC | ||
| FILE_SET CXX_MODULES FILES scan_view.cppm | ||
| FILE_SET HEADERS | ||
| FILES | ||
| config.hpp | ||
| scan.hpp | ||
| "${PROJECT_BINARY_DIR}/include/beman/scan_view/config_generated.hpp" | ||
| ) | ||
| else() | ||
| target_sources( | ||
| beman.scan_view | ||
| PUBLIC | ||
| FILE_SET HEADERS | ||
| FILES | ||
| config.hpp | ||
| scan.hpp | ||
| "${PROJECT_BINARY_DIR}/include/beman/scan_view/config_generated.hpp" | ||
| ) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef BEMAN_SCAN_VIEW_CONFIG_HPP | ||
| #define BEMAN_SCAN_VIEW_CONFIG_HPP | ||
|
|
||
| #if !defined(__has_include) || __has_include(<beman/scan_view/config_generated.hpp>) | ||
| #include <beman/scan_view/config_generated.hpp> | ||
| #else | ||
| #define BEMAN_SCAN_VIEW_USE_MODULES() 0 | ||
| #endif | ||
|
|
||
| #endif |
|
Mick235711 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef BEMAN_SCAN_VIEW_CONFIG_GENERATED_HPP | ||
| #define BEMAN_SCAN_VIEW_CONFIG_GENERATED_HPP | ||
|
|
||
| #cmakedefine01 BEMAN_SCAN_VIEW_USE_MODULES() | ||
|
|
||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.