Update flag forking approach to use split config.hpp and config_generated.hpp files#128
Merged
Update flag forking approach to use split config.hpp and config_generated.hpp files#128
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ated.hpp files This commit reflects the new flag forking approach discussed in the most recent Beman weekly sync: - For any configuration option where a compiler flag could cause differences in behavior that lead to ODR issues when linking two artifacts generated with different flags, maintainers generate a compiler definition like BEMAN_EXEMPLAR_FOOBAR into a config_generated.hpp header from a config_generated.hpp.in template. - Separately, a config.hpp file contains defaults for each definition. These defaults are only enabled if __has_include shows that the config_generated.hpp file is not present.
ednolan
changed the title
|
coverage: 98.649%. remained the same — enolan_flagfork1 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reflects the new flag forking approach discussed in the
most recent Beman weekly sync:
For any configuration option where a compiler flag could cause
differences in behavior that lead to ODR issues when linking two
artifacts generated with different flags, maintainers generate a
compiler definition like BEMAN_EXEMPLAR_FOOBAR into a
config_generated.hpp header from a config_generated.hpp.in template.
Separately, a config.hpp file contains defaults for each
definition. These defaults are only enabled if __has_include shows
that the config_generated.hpp file is not present.