Skip to content

Update bem-core to 4.3.1 #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tadatuta wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

Update bem-core to 4.3.1 #2099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8610997
Get rid of lazyInit in declMod
tadatuta Jul 23, 2018
212a54f
Update bem-core to 4.3.1
tadatuta Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"!LICENSE.txt"
],
"dependencies": {
"bem-core": "4.2.0"
"bem-core": "4.3.1"
},
"devDependencies": {
"bem-pr": "~0.13.0"
Expand Down
2 changes: 0 additions & 2 deletions common.blocks/checkbox/_type/checkbox_type_button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ provide(Checkbox.declMod({ modName : 'type', modVal : 'button' }, /** @lends che
}
}
}, /** @lends checkbox */{
lazyInit : true,
onInit : function() {

this._events(Button).on({ modName : 'js', modVal : 'inited' }, functions.noop);
return this.__base.apply(this, arguments);
}
Expand Down
1 change: 0 additions & 1 deletion common.blocks/menu/__item/_type/menu__item_type_link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ provide(MenuItem.declMod({ modName : 'type', modVal : 'link' }, /** @lends menu_
this.setMod('hovered');
}
}, /** @lends menu__item */{
lazyInit : true,
onInit : function() {
this._domEvents().on('focusin', this.prototype._onFocus);
return this.__base.apply(this, arguments);
Expand Down
1 change: 0 additions & 1 deletion common.blocks/popup/_autoclosable/popup_autoclosable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ provide(Popup.declMod({ modName : 'autoclosable', modVal : true }, /** @lends po
this.delMod('visible');
}
}, /** @lends popup */{
lazyInit : true,
onInit : function() {
// TODO: checkme!
// this._domEvents(bemDom.doc).on(KEYDOWN_EVENT, onDocKeyPress);
Expand Down
1 change: 0 additions & 1 deletion common.blocks/radio-group/_mode/radio-group_mode_radio-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ provide(RadioGroup.declMod({ modName : 'mode', modVal : 'radio-check' }, /** @le
this._checkedRadio === e.target && this.setVal(undef);
}
}, /** @lends radio-group */{
lazyInit : true,
onInit : function() {
this._events(Radio).on(
{ modName : 'checked', modVal : '' },
Expand Down
1 change: 0 additions & 1 deletion common.blocks/radio/_type/radio_type_button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ provide(Radio.declMod({ modName : 'type', modVal : 'button' }, /** @lends radio.
}
}
}, /** @lends radio */{
lazyInit : true,
onInit : function() {
this._events(Button).on({ modName : 'js', modVal : 'inited' }, Functions.noop);
return this.__base.apply(this, arguments);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
],
"dependencies": {},
"peerDependency": {
"bem-core": "^4.2.0"
"bem-core": "^4.3.1"
},
"devDependencies": {
"autoprefixer": "^6.4.0",
Expand Down