Skip to content

Non DOM blocks destruction #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
corpix wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Non DOM blocks destruction #566

corpix wants to merge 1 commit into from

Conversation

@corpix
Copy link
Contributor

@corpix corpix commented Nov 6, 2014

There are hanged event listeners on non DOM blocks after instance.destruct(). This PR should fix this.

@tadatuta
Copy link
Member

tadatuta commented Nov 6, 2014

@dfilatov please take a look

@deeonis
Copy link
Contributor

deeonis commented Jun 5, 2015

@dfilatov ping

@andre487
Copy link
Contributor

andre487 commented Jun 6, 2015

But why not this.domElem.remove()?

@corpix
Copy link
Contributor Author

corpix commented Jun 7, 2015

@Andre-487 this is i-bem part for blocks without DOM.

@andre487
Copy link
Contributor

andre487 commented Jun 7, 2015

Ok, I get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corpix @tadatuta @deeonis @andre487