Skip to content

Make yandex-metrica generated HTML a bit smaller #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tadatuta wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make yandex-metrica generated HTML a bit smaller #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da67643
Drop useless code
tadatuta Feb 7, 2017
5b7b905
Update 00-basic.html
tadatuta Feb 7, 2017
102ab51
Update 10-csp-nonce.html
tadatuta Feb 7, 2017
024550f
Update yandex-metrica.bh.js
tadatuta Feb 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions common.blocks/yandex-metrica/yandex-metrica.bemhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,16 @@ block('yandex-metrica').replace()(function() {
' var n = d.getElementsByTagName("script")[0],',
' s = d.createElement("script"),',
' f = function () { n.parentNode.insertBefore(s, n); };',
' s.type = "text/javascript";',
' s.async = true;',
Copy link
Member Author

@tadatuta tadatuta Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text/javascript is default value

Copy link
Member

@remnev remnev Feb 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, but why Metrica provides this attribute? May be it brings value for using in old browsers?

Copy link
Member Author

@tadatuta tadatuta Feb 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should care for such old browsers.

' s.src = "https://mc.yandex.ru/metrika/watch.js";',
'',
' if (w.opera == "[object Opera]") {',
' d.addEventListener("DOMContentLoaded", f, false);',
' } else { f(); }',
'})(document, window, "yandex_metrika_callbacks");'
].join('\n');
].join('');

Copy link
Member Author

@tadatuta tadatuta Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should safe ~35 bytes :)

noScriptContent = {
tag : 'div',
content : {
tag : 'img',
Copy link
Member Author

@tadatuta tadatuta Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div is default value

attrs : {
Expand Down
4 changes: 1 addition & 3 deletions common.blocks/yandex-metrica/yandex-metrica.bh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,16 @@ module.exports = function (bh) {
' var n = d.getElementsByTagName("script")[0],',
' s = d.createElement("script"),',
' f = function () { n.parentNode.insertBefore(s, n); };',
' s.type = "text/javascript";',
' s.async = true;',
' s.src = "https://mc.yandex.ru/metrika/watch.js";',
'',
' if (w.opera == "[object Opera]") {',
' d.addEventListener("DOMContentLoaded", f, false);',
' } else { f(); }',
'})(document, window, "yandex_metrika_callbacks");'
].join('\n');
].join('');

noScriptContent = {
tag : 'div',
content : {
tag : 'img',
attrs : {
Expand Down
2 changes: 1 addition & 1 deletion common.blocks/yandex-metrica/yandex-metrica.tmpl-specs/00-basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<script>(function (d, w, c) { (w[c] = w[c] || []).push(function() { try { w.yaCounter12345 = new Ya.Metrika({"id":"12345"}); } catch(e) { } }); var n = d.getElementsByTagName("script")[0], s = d.createElement("script"), f = function () { n.parentNode.insertBefore(s, n); }; s.type = "text/javascript"; s.async = true; s.src = "https://mc.yandex.ru/metrika/watch.js"; if (w.opera == "[object Opera]") { d.addEventListener("DOMContentLoaded", f, false); } else { f(); }})(document, window, "yandex_metrika_callbacks");</script><noscript><div><img src="//mc.yandex.ru/watch/12345" style="position:absolute; left:-9999px;"/></div></noscript>
<script>(function (d, w, c) { (w[c] = w[c] || []).push(function() { try { w.yaCounter12345 = new Ya.Metrika({"id":"12345"}); } catch(e) { } }); var n = d.getElementsByTagName("script")[0], s = d.createElement("script"), f = function () { n.parentNode.insertBefore(s, n); }; s.async = true; s.src = "https://mc.yandex.ru/metrika/watch.js"; if (w.opera == "[object Opera]") { d.addEventListener("DOMContentLoaded", f, false); } else { f(); }})(document, window, "yandex_metrika_callbacks");</script><noscript><div><img src="//mc.yandex.ru/watch/12345" style="position:absolute; left:-9999px;"/></div></noscript>
1 change: 0 additions & 1 deletion common.blocks/yandex-metrica/yandex-metrica.tmpl-specs/10-csp-nonce.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
var n = d.getElementsByTagName("script")[0],
s = d.createElement("script"),
f = function () { n.parentNode.insertBefore(s, n); };
s.type = "text/javascript";
s.async = true;
s.src = "https://mc.yandex.ru/metrika/watch.js";

Expand Down