Skip to content
This repository was archived by the owner on Nov 26, 2021. It is now read-only.

Change from SCSS to plain CSS#5

Open
mawiswiss wants to merge 8 commits intobellevue7k:masterfrom
mawiswiss:master
Open

Change from SCSS to plain CSS#5
mawiswiss wants to merge 8 commits intobellevue7k:masterfrom
mawiswiss:master

Conversation

@mawiswiss
Copy link
Collaborator

To use the reset for example in react projects with styled-components we need to have the file available in plain CSS. We discussed this issue already earlier in #4.

As it's a breaking change we need to bump the version to 2.0.0.

@mawiswiss
Copy link
Collaborator Author

We're ready here.

@j3ll3yfi5h Do you have any breaking styling changes? It's would be the time to introduce it now. I noticed some issues with the button styling (border) and the white background on html/body.

@j3ll3yfi5h
Copy link
Collaborator

j3ll3yfi5h commented Jan 3, 2020

@marcwieland95

Please add:

html {
	height: 100%;
}

body {
	min-height: 100%;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants