Fix potential memory leak when source listeners are removed from layout.#4060
Closed
corranwebster wants to merge 5 commits intobeeware:mainfrom
Closed
Fix potential memory leak when source listeners are removed from layout.#4060corranwebster wants to merge 5 commits intobeeware:mainfrom
corranwebster wants to merge 5 commits intobeeware:mainfrom
Conversation
This is a fix for beeware#4030 for DetailedList, Table and Tree.
corranwebster
changed the title
4 tasks
Contributor
Author
|
I'm going to close this based on the discussion in #4030. Any solution which looks like this will need much deeper architectural changes around widget life-cycles and would essentially be a complete re-write. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #4030 for DetailedList, Table and Tree.
This adds callbacks to two new private base Widget methods that subclasses can use to do any clean-up before being removed from layout and any restoration needed when being added into the layout. For the DetailedList, Table and Tree we disconnect the listeners on the source on removal, and re-connect and refresh the data when added back.
The selected rows are lost when adding back into the layout, but I think that's OK.
Ref #4030.
PR Checklist: