Run pre-commit with latest Python#344
Conversation
This reverts commit e3c1d0e.
|
Bumping docformatter to v1.7.8 in .pre-commit-config.yaml should fix the builds for The failed |
|
Thanks - as you've noted, I'm guessing this will pass CI once dependabot has run on the downstream repos. |
|
I just realized that Dependabot is not configured to update pre-commit hooks, so this won't resolve itself (pre-commit support in Dependabot is a pretty new feature). How would a good resolution look like? I could spend some time on this in the next days.
|
I missed that announcement in Dependabot - but we've already worked around this. We have an independent pre-commit update workflow that is (or should be) installed on every repository. It runs on Sunday for "core" repositories, and on the first Sunday of the month for every other repository.
This is what we should be aiming for. PyCon US sprints are coming up, and this sort of upgrade is good fodder for first time contributors. It's not super urgent that it be done, it's relatively easy to explain, and it's spread across a lot of repositories. |
|
CI now passes; but we can't merge until beeware/briefcase#2815 has been merged. That's the last active reference to docformatter that I can find that hasn't been updated. |
This PR reverts #260, which pinned the pre-commit Python version to 3.13 until docformatter supports 3.14.
97ac9c5 removed docformatter from the pre-commit config, so that bandaid is not necessary anymore.
Also, docformatter v1.7.8 was just released, now supporting Python 3.14: PyCQA/docformatter#342.
PR Checklist:
Sorry, I don't know how to test or document this.