feat(mariner): spot soundings as their own switch, not the OTHER category#15
Merged
Conversation
…gory S-52 files SOUNDG under the OTHER display category, but every ECDIS gives soundings their own control, and the everyday setting is STANDARD + soundings ON. A host that wants that today has to enable the whole OTHER category — and takes the seabed, the cables, the obstruction depths and the rest of the low-priority detail with it. On a Boston harbour tile that is 30 soundings bought at the price of 70 features of clutter. Settings.show_soundings is an optional bool, so null keeps the old behaviour exactly (soundings follow the category) and no existing caller changes. On the C ABI the field is a tri-state u8 appended at the end (0 = follow category, 1 = show, 2 = hide), so a zeroed tile57_mariner from an older host still means 'follow the category'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S-52 files SOUNDG under the OTHER display category, but every ECDIS gives soundings their own control, and the everyday setting is STANDARD + soundings ON. A host that wants that today has to enable the whole OTHER category — and takes the seabed, the cables, the obstruction depths and the rest of the low-priority detail with it. On a Boston harbour tile that is 30 soundings bought at the price of 70 features of clutter.
Settings.show_soundings is an optional bool, so null keeps the old behaviour exactly (soundings follow the category) and no existing caller changes. On the C ABI the field is a tri-state u8 appended at the end (0 = follow category, 1 = show, 2 = hide), so a zeroed tile57_mariner from an older host still means 'follow the category'.