Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
grug see PR try make docs link not rot. no code logic change. just docs hygiene so people click link and not cry.
Changes:
- change many docs URLs to new https + new canonical places
- add Sphinx
linkcheck_ignorefor sites that block robots / need login - add changelog note about docs URL update
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/reference/query.rst | update Python re docs link to /3/ path |
| docs/reference/pathformat.rst | update Python string docs link + MusicBrainz sample link |
| docs/reference/cli.rst | update PyPI rarfile link |
| docs/plugins/web.rst | update nginx + flask doc links |
| docs/plugins/thumbnails.rst | update ImageMagick link |
| docs/plugins/subsonicupdate.rst | upgrade Subsonic links to https |
| docs/plugins/spotify.rst | update Spotify Web API reference links |
| docs/plugins/sonosupdate.rst | update Sonos link |
| docs/plugins/replaygain.rst | update several dependency/tool links (PyGObject, aacgain, mp3gain, etc.) |
| docs/plugins/plexupdate.rst | update Plex token doc link + Plex site link |
| docs/plugins/musicbrainz.rst | update MusicBrainz “building search indexes” link |
| docs/plugins/lyrics.rst | update Google CSE + Sphinx/docutils links |
| docs/plugins/lastimport.rst | update Last.fm link |
| docs/plugins/lastgenre.rst | update Last.fm link + Wikipedia scrape script link |
| docs/plugins/keyfinder.rst | upgrade keyfinder link to https |
| docs/plugins/ipfs.rst | update IPFS + go-ipfs (kubo) links |
| docs/plugins/info.rst | update id3v2 link |
| docs/plugins/index.rst | update many plugin index reference links (deezer/spotify/plex/sonos/subsonic/etc.) |
| docs/plugins/hook.rst | update PEP-3101 link to peps.python.org |
| docs/plugins/fetchart.rst | update Google CSE + ImageMagick links |
| docs/plugins/embedart.rst | update ImageMagick + archive phash link |
| docs/plugins/discogs.rst | update Discogs base link + example album link |
| docs/plugins/deezer.rst | update Deezer base link + example URL |
| docs/plugins/convert.rst | update LAME + HydrogenAudio wiki links |
| docs/plugins/bpd.rst | update several client/protocol links (SourceForge, fandom, mpd docs) |
| docs/plugins/beatport.rst | update Discogs base link |
| docs/plugins/badfiles.rst | update mp3val link |
| docs/plugins/aura.rst | update Flask/uwsgi/proxy-related links |
| docs/plugins/absubmit.rst | update requests docs link to /latest/ |
| docs/guides/installation.rst | update Python/pip + distro package links |
| docs/faq.rst | update pastebin + bug-writing guideline + id3v2 + superuser links |
| docs/dev/plugins/other/logging.rst | update PEP-3101 link |
| docs/dev/plugins/index.rst | replace SO shortlink with full question URL |
| docs/dev/plugins/commands.rst | update optparse links to /3/ |
| docs/conf.py | add more linkcheck_ignore patterns |
| docs/changelog.rst | add entry about URL updates + refresh many historical reference links |
| README_kr.rst | update Codecov link to app.codecov.io |
| README.rst | update Codecov link to app.codecov.io |
| CONTRIBUTING.rst | update Codecov + PEP + logging/stdtypes links; replace test template link with test-query ref |
| CODE_OF_CONDUCT.rst | adjust Contributor Covenant link (trailing slash) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6418 +/- ##
==========================================
- Coverage 69.34% 69.33% -0.01%
==========================================
Files 141 141
Lines 18443 18443
Branches 3019 3019
==========================================
- Hits 12789 12788 -1
- Misses 5018 5019 +1
Partials 636 636 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Link Maintenance
This PR audits and fixes all hyperlinks across the beets documentation. No functional code changes — purely doc hygiene.
What changed
http://links tohttps://where supported.codecov.io→app.codecov.iodocs.python.org/library/→docs.python.org/3/library/python.org/dev/peps/→peps.python.org/web.archive.orgwhere the original is gone (e.g.echonest,albumart.org,phash)docs/conf.py: Adds link-check exclusions for domains known to block automated requests (SourceForge, fanart.tv, Imgur, Discogs settings).Impact
No user-facing behaviour changes. Fixes broken links that would frustrate contributors and users reading the docs, and unblocks the Sphinx
linkcheckbuilder from false positives.