Lastgenre: Split last.fm fetching and file loading to separate files

[JOJ0]

Description

• Separation of concerns
  • API client
  • file loading
  • plugin logic
• Factory pattern for configuration-based initialization (follows some ideas as recently seen in a Beets Discogs plugin refactor)
• Static methods group utilities with their logical owners
  • flatten_tree() → DataFileLoader (tree processing)
  • find_parents() → LastGenrePlugin (genre canonicalization)
• Prepare for future features, especially additional datafile loading (artist-based genre blacklist, regex genre spelling normalization)

New modules

• utils.py - Shared utilities with make_tunelog() factory for bound logging functions
• client.py - Last.fm API client (LastFmClient) extracted from main plugin
• loaders.py - Data file loader (DataFileLoader) with from_config() factory pattern
• types.py - Named types for parsed whitelist and canonicalization tree(prepare for future datafile formats)

No functional changes - pure refactoring to improve structure.

To Do

• Documentation.
• Changelog. (Prevent merge conflicts for now -> later)
• Tests. (Adapted existing tests to changes)

[codecov]

Codecov Report

❌ Patch coverage is 60.81081% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.41%. Comparing base (573dca6) to head (42b0d45).
⚠️ Report is 35 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
beetsplug/lastgenre/client.py	55.10%	21 Missing and 1 partial ⚠️
beetsplug/lastgenre/__init__.py	70.58%	4 Missing and 1 partial ⚠️
beetsplug/lastgenre/utils.py	75.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6368      +/-   ##
==========================================
+ Coverage   69.32%   69.41%   +0.08%     
==========================================
  Files         141      143       +2     
  Lines       18786    18819      +33     
  Branches     3060     3063       +3     
==========================================
+ Hits        13024    13063      +39     
+ Misses       5117     5110       -7     
- Partials      645      646       +1     

Files with missing lines	Coverage Δ
beetsplug/lastgenre/utils.py	75.00% <75.00%> (ø)
beetsplug/lastgenre/__init__.py	76.31% <70.58%> (+5.90%)	⬆️
beetsplug/lastgenre/client.py	55.10% <55.10%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR refactors the lastgenre plugin into a modular structure by extracting Last.fm API client, file loaders, and utilities into separate modules. The refactoring maintains all existing functionality while improving code organization and preparing for future enhancements.

Changes:

• Created four new modules (utils.py, types.py, loaders.py, client.py) to separate concerns
• Applied factory pattern (from_config()) for configuration-based initialization, consistent with other plugins
• Moved static helper methods to their logical owners (flatten_tree → DataFileLoader, find_parents → LastGenrePlugin)

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
beetsplug/lastgenre/utils.py	New module with shared utilities including make_tunelog() factory for bound logging
beetsplug/lastgenre/types.py	New module defining type aliases for Whitelist, CanonTree, and GenreCache
beetsplug/lastgenre/loaders.py	New module with DataFileLoader class for loading whitelist and canonicalization tree files
beetsplug/lastgenre/client.py	New module with LastFmClient class extracted from main plugin for Last.fm API interactions
beetsplug/lastgenre/init.py	Refactored main plugin to use new modular structure, removing ~180 lines of code
test/plugins/test_lastgenre.py	Updated tests to reflect new module structure (client methods now accessed via plugin.client)
docs/changelog.rst	Added changelog entries documenting the refactoring and separator option removal

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.