Open
Conversation
krugerk
commented
Feb 24, 2026
krugerk
commented
Feb 24, 2026
krugerk
commented
Feb 24, 2026
krugerk
commented
Feb 25, 2026
| url: "api/v1/users/{username}/goals/\(goal.slug)/datapoints/\(datapoint.id).json", | ||
| parameters: params | ||
|
|
||
| let _ = try await requestManager.request( |
Contributor
Author
There was a problem hiding this comment.
_ = ...
Can also be used throughout, without the let.
Contributor
Author
There was a problem hiding this comment.
would include SwiftLint for checking this
krugerk
force-pushed
the
feature/endpoint-enum
branch
from
d46a6f0 to
ded094d
Compare
krugerk
changed the title
krugerk
force-pushed
the
feature/endpoint-enum
branch
from
ded094d to
96f760f
Compare
krugerk
commented
Mar 10, 2026
Contributor
Author
There was a problem hiding this comment.
could easily be its own should this PR be too big/busy
krugerk
force-pushed
the
feature/endpoint-enum
branch
from
52b9e75 to
53e0be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trying a type for the API endpoint. Avoids much of the manual string manipulation and substring replacement.
Also provides a SSoT with regard to the url for an endpoint - the rest of the app does not need to deal with url paths, parameters, or http verbs.
Several places that had access to a username now pass it along rather than relying on the request manager to perform the substitution.