Configure rubocop #3446
Closed
Configure rubocop #3446
+1,353
−1,296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joshuay03
force-pushed
the
configure-rubocop
branch
from
f7f02a3 to
58c83d0
Compare
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
force-pushed
the
configure-rubocop
branch
from
e63a944 to
b023b09
Compare
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
joshuay03
force-pushed
the
configure-rubocop
branch
from
b023b09 to
9b3c9da
Compare
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
joshuay03
force-pushed
the
configure-rubocop
branch
from
9b3c9da to
b25b564
Compare
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
joshuay03
force-pushed
the
configure-rubocop
branch
from
b25b564 to
6601d0c
Compare
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
joshuay03
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
zinduolis
reviewed
Nov 16, 2025
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Checkout the repository" | ||
| uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Version 5 has been recently released. Can we please use it instead of 4 is possible?
zinduolis
reviewed
Nov 16, 2025
|
|
||
| - name: 'Checkout the repository' | ||
| - name: "Checkout the repository" | ||
| uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Can we please use version 5 if possible?
zinduolis
reviewed
Nov 17, 2025
| xssraysdetails = BeEF::Core::Models::Xssraysdetail.where(hooked_browser_id: hb.id) | ||
| xssraysdetails.destroy_all | ||
| rescue StandardError => e | ||
| rescue StandardError |
Contributor
There was a problem hiding this comment.
Can the error at least be logged?
zinduolis
reviewed
Nov 17, 2025
Contributor
There was a problem hiding this comment.
What's the purpose of loosening the conditions?
zinduolis
reviewed
Nov 17, 2025
| configuration = BeEF::Core::Configuration.instance | ||
| proto = configuration.get('beef.http.https.enable') == true ? 'https' : 'http' | ||
| hook_uri = "#{proto}://#{configuration.get('beef.http.host')}:#{configuration.get('beef.http.port')}/demos/report.html" | ||
| # configuration = BeEF::Core::Configuration.instance |
Contributor
There was a problem hiding this comment.
What's the purpose of commenting these out?
zinduolis
reviewed
Nov 17, 2025
| ip = Regexp.last_match(2) | ||
| port = Regexp.last_match(3) | ||
| url = Regexp.last_match(4) | ||
| Regexp.last_match(4) |
Contributor
There was a problem hiding this comment.
What's the purpose of this?
zinduolis
reviewed
Nov 17, 2025
| port = Regexp.last_match(3) | ||
| discovered = Regexp.last_match(4) | ||
| url = Regexp.last_match(5) | ||
| Regexp.last_match(5) |
Contributor
There was a problem hiding this comment.
What's the purpose of this?
zinduolis
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Category
Maintenance
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: TODO
Q: Give a technical rundown of what you have changed (if applicable)
A: TODO