Skip to content

[common]: use multiple existing tls certificates#100

Open
LeTT00r wants to merge 6 commits intobedag:masterfrom
LeTT00r:multiple_tls_certificates
Open

[common]: use multiple existing tls certificates#100
LeTT00r wants to merge 6 commits intobedag:masterfrom
LeTT00r:multiple_tls_certificates

Conversation

@LeTT00r
Copy link
Copy Markdown

@LeTT00r LeTT00r commented Jun 13, 2023

What this PR does:

adds the ability to implement multiple existing tls certificates to ingress

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

Signed-off-by: MichaelBjeski <blabor@posteo.net>
@LeTT00r LeTT00r requested review from a team and oliverbaehler June 13, 2023 13:49
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 13, 2023
@adberger
Copy link
Copy Markdown
Contributor

helm-test / lint-test is failing, please fix.
Would also be nice to have multiple tls.provided so there is no need to create separate Secrets beforehand.
Why are there so many changes in charts/common/values.schema.json?

fix: set host for each certificate directly

Signed-off-by: MichaelBjeski <blabor@posteo.net>
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 14, 2023
LeTT00r added 3 commits June 14, 2023 08:22
Signed-off-by: MichaelBjeski <blabor@posteo.net>
Signed-off-by: MichaelBjeski <blabor@posteo.net>
Signed-off-by: MichaelBjeski <blabor@posteo.net>
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023
Signed-off-by: MichaelBjeski <blabor@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants