Gate debug control UI behind runtime env flag#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1f85c3c41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| display: none; | ||
| } | ||
|
|
||
| html[data-debug-ui='true'] .eli5-control-dock { | ||
| width: min(390px, calc(100vw - 24px)); |
There was a problem hiding this comment.
Re-enable control dock when debug UI is active
This change hides .eli5-control-dock by default, but the debug override only restores width and never restores display, so the inline dock remains invisible even when debug UI is enabled. In practice, that breaks the fallback path where controls should appear in-page (for example when the popup window cannot open), leaving debug controls inaccessible in dev/debug sessions.
Useful? React with 👍 / 👎.
Motivation
Description
isDebugUIEnabledinsrc/App.jsxusingimport.meta.env.DEV || import.meta.env.VITE_ENABLE_DEBUG_UI === 'true'and used it when initializing and reading app view state./key handler, and the quick navigation actions between Depth Lab and Typography Lab.readAppViewand runtime view changes ignore debug-only views when debug UI is disabled, and the app will force the view back to home if needed.document.documentElement.dataset.debugUi) and a CSS safety net insrc/styles.cssthat keeps.eli5-control-launcherand.eli5-control-dockhidden unlesshtml[data-debug-ui='true']is set.docs/development.mddocumenting the env switch and the local command to enable debug UI (VITE_ENABLE_DEBUG_UI=true).Testing
npm run buildand it completed successfully.Codex Task