Skip to content

fix/remove-custom-progressbar#1178

Draft
wyzula-jan wants to merge 2 commits into
mainfrom
fix/remove-custom-progressbar
Draft

fix/remove-custom-progressbar#1178
wyzula-jan wants to merge 2 commits into
mainfrom
fix/remove-custom-progressbar

Conversation

@wyzula-jan
Copy link
Copy Markdown
Contributor

@wyzula-jan wyzula-jan commented May 28, 2026

Description

Since this widget is present in MainWindow, it should be rock solid. ScanProgressbar refactored to not use its own custom paintEvent based progress bar but rather native QProgressBar.

To avoid merge conflict I would prefer to merge after #1175

@wyzula-jan wyzula-jan self-assigned this May 28, 2026
@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch from cee4514 to dd7e029 Compare May 29, 2026 07:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 5.82713 s 6.01706 s +3.26% ok
BEC IPython client without companion app 1.91878 s 2.08061 s +8.43% ok
Import bec_widgets 0.0130001 s 0.0132713 s +2.09% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.147591 s 0.154306 s +4.55% ok

@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch 4 times, most recently from 980e0dc to 3b4ec66 Compare June 2, 2026 13:19
@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch from 354f688 to b0faeb5 Compare June 2, 2026 15:06
@wyzula-jan wyzula-jan force-pushed the fix/remove-custom-progressbar branch from b0faeb5 to b6b768e Compare June 2, 2026 15:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant