Open
Conversation
Owner
|
Thanks for the PR! I haven't touched this in like forever (mostly because I stopped working on the project I was using this for), and the original intention was as an example, so I'll have to review this to make sure it's not becoming too application-y. I'll take a look at this once I get some time. I can't promise a time frame though. |
Author
|
NP. Just some more feedback. I tried the code on AIX/HPUX/Solaris and it failed miserably with both gcc and proprietary compilers :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
I made those changes while trying to write a test pam module to help with my automated tests.
It updates the README and adds password conversation so that you can check the password.
Changes
Not all pam modules are located in
/lib/security/.On my Ubuntu 14.04 they are in /lib/x86_64-linux-gnu/security/
I find the putting them in /tmp/ is easier as the pam conf file allow absolute paths.
To link it to pam you need to pass
-lpamRather than messing with common-auth or any existing service I think that it is better to create a dedicated pam service configuration.
I have extended pam_test to also get the service name as argument.
I found that the auth check part from the test was strange... please check that the changes from test.c are ok
Feel free to reject it or to merge only part of this PR.
How to test
Folllow the insctruction from the README file
allowed account test-user/test-pass
Thanks!