Update for streamlink release 4.0+#33
Open
TheKeeperOfPie wants to merge 1 commit intobeardypig:masterfrom
Open
Update for streamlink release 4.0+#33TheKeeperOfPie wants to merge 1 commit intobeardypig:masterfrom
TheKeeperOfPie wants to merge 1 commit intobeardypig:masterfrom
Conversation
TheKeeperOfPie
commented
Jun 6, 2022
| fi | ||
| echo "${sha256} ${cache_dir}/${filename}" | sha256sum --check - | ||
| done < <(jq -r '.[] | "\(.filename) \(.sha256) \(.url)"' <<< "${ASSETS_DATA}") | ||
| if [[ "${STREAMLINK_PYTHON_ARCH}" == "amd64" ]]; then |
Contributor
Author
There was a problem hiding this comment.
I'm not very familiar with bash, so I don't know how to do string var replacement when piping a command into a while loop. I tried making it use a quoted string, but it wasn't able to resolve the command like that.
This also doesn't handle non-ffmpeg assets, which are theoretically possible, but not currently in the config. I'm definitely not familiar enough with bash to write this generically.
Fixes:
- Windows build instruction to include missing dependencies
- Enforced minimum Python 3.9 by removing old workflows
- Updates JSON parsing to account for new windows-installer config
Test: manual, bring up a fresh Ubuntu WSL2 instance and invoke builds
for win32 and amd64
|
@TheKeeperOfPie, @beardypig: Any progress on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Test: manual, bring up a fresh Ubuntu WSL2 instance and invoke builds
for win32 and amd64