Skip to content

Conversation

@nolanamy
Copy link

@nolanamy nolanamy commented Nov 13, 2017

Fixes #67.

So, clearly the "complex" parameter thing is overly complex...

This gets fulfillment working, uses a much simpler approach to list-of-object parameters, and standardizes fulfillment parameter names a bit. Also improves error handling and messages for both missing and unknown parameters, including for list and list-of-object types.

I successfully tested ListInventorySupply, GetFulfillmentPreview, CreateFulfillmentOrder, ListAllFulfillmentOrders, and GetFulfillmentOrder with a live FBA account.

Thanks to forks:

@florianbepunkt
Copy link

florianbepunkt commented Nov 19, 2017

@nolanamy Looks good for me. One small thing though… for createFullfillmentOrder could you also add the MarketplaceId param (see here http://docs.developer.amazonservices.com/en_DE/fba_outbound/FBAOutbound_CreateFulfillmentOrder.html)

If you use multi-channel fulfillment in multiple countries with marketplace inventory you need to specify the maketplace id in order to sucessfully place a fulfillment order.

@nolanamy
Copy link
Author

@florianbepunkt Added optional MarketplaceId to CreateFulfillmentOrder, GetFulfillmentPreview, and UpdateFulfillmentOrder. Tested the first two (Create and Preview) with no value as well as with 'ATVPDKIKX0DER' (US); seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants