Rename CMake build_tests and BUILD_SHARED_LIBS options #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CMakeLists.txt (build_tests): Change default value to ON. * README_details.txt (USAGE): Do not pass `-Dbuild_tests=ON` to cmake.
`BUILD_TESTING` is the "standard" on-by-default variable provided by `CTest` module. * CMakeLists.txt (build_tests): Rename option to `BUILD_TESTING`; comment out `option()` command for `BUILD_TESTING`.
This is to avoid usage/redefinition of `BUILD_SHARED_LIBS` standard cmake variable as the project might be included as a subdirectory. * CMakeLists.txt (BUILD_SHARED_LIBS): Rename option to `AO_BUILD_SHARED_LIBS`. * CMakeLists.txt [AO_BUILD_SHARED_LIBS] (atomic_ops): Pass `SHARED` to `add_library()`. * CMakeLists.txt [enable_gpl && AO_BUILD_SHARED_LIBS] (atomic_ops_gpl): Likewise. * CMakeLists.txt [!AO_BUILD_SHARED_LIBS] (atomic_ops): Pass `STATIC` to `add_library()`. * CMakeLists.txt [enable_gpl && !AO_BUILD_SHARED_LIBS] (atomic_ops_gpl): Likewise.
Member
Author
|
Builds are OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AO_